ci(supply-chain): make cargo-deny-supply-chain blocking - #43
Merged
Conversation
The bans/licenses policy is fully seeded in deny.toml (permissive licenses allowed, GPL-3.0 scoped per-crate to the Zed gpui crates, unlicensed git crates MIT-clarified, git-dep wildcards set to warn) and the job is green on main. Drop continue-on-error so a new banned crate / disallowed license / untrusted source blocks the merge. Completes the #40 gate work. https://claude.ai/code/session_01JewEHPGHCWy5DWnmLD9DGy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops
continue-on-errorfrom thecargo-deny-supply-chainjob now that bans/licenses are fully seeded indeny.tomland the job is green onmain(verified in #42).A new banned crate, disallowed license, or untrusted git source now blocks the merge instead of just warning. Completes the gate work in #40.
Pairs with adding
cargo-deny-supply-chainto branch protection onmain(done alongside this).